- Does the code work as expected?
- Does the code follow the StyleCop/FxCop/JSLint/SonarLint rules?
- Review static analysis warning suppressions if any.
- Do you see any code duplication?
- Please refer the Portal Standardization sheet as well while implementation
- Is there any copy-pasted code from any other source?
- Does the code follow a modular structure?
- Validate code metrics.
- Is there any code that is commented out?
- Are there any TODO markers or any incomplete code?
- Is proper authentication and authorization in place? Validate across personas
- Adequate logging (Verbose, Warning, Error etc.)?
- Does the code handle all exception scenarios?
- · What happens if call to external system fail?
- · What happens if the call to database fails?
- Can the number of database queries be optimized?
- Proper use of cache?
- Review transactions
- Do methods and functions validate inputs before using it?
- Are comments present and are they appropriate?
- Do loops have proper terminating conditions?
- Do methods have too many parameters?
- Do methods, classes etc. have meaningful names?
- Does the code perform excessive string concatenation?
- For custom exception classes, does the code implement the standard exception pattern?
- For classes that need to implement, do they implement the standard dispose pattern?
- Does the code use dynamic SQL?
- Does the code implement guidelines to avoid XSS attack
- Does the code implement technique to avoid CSRF attack
- Each UI control should have corresponding ID for automation purpose.
- For a control type(ex : dropdown), across the pages it should have same control properties.
- TFS task status update
- Link TFS ID with check-in
- Deployment Scripts, RM updated if applicable
- Verified the successful deployment in Dev integration environment
Life is a Short Span, try to earn knowledge in every Field.
Monday, 2 December 2024
Developer and Reviewer Checklist - Keep Handy while Developing Code
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment